Skip to content

fix(GlButton): Default all dropdown button icon sizes to 16

Jarek Ostrowski requested to merge 1250-update-dropdown-icon-only-icon-size into main

What does this MR do?

Closes #1250 (closed). All icons in buttons and dropdown buttons should use 16 as the default size. Based on Figma designs: https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=22298%3A13380. This came up during a change to the notifications dropdown button, which contains a smaller icon than it's adjacent small button counterparts:

Screen_Shot_2021-03-10_at_5.29.34_PM

Before After
Screen_Shot_2021-03-10_at_5.08.10_PM Screen_Shot_2021-03-10_at_5.24.53_PM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

N/A

Accessibility

N/A

Closes #1250 (closed)

Edited by Jeremy Elder

Merge request reports