Skip to content

Resolve "Add borderless (tertiary) loading button variant"

What does this MR do?

  • Eliminate the orange spinner in favor of the neutral spinner.
  • Add a tertiary loading button variant.

See this thread for context #1029 (comment 431080670).

CleanShot_2020-10-22_at_15.03.15_2x

Examples from the integration MR

CleanShot_2020-10-28_at_09.59.58

CleanShot_2020-10-28_at_10.00.31

CleanShot_2020-10-28_at_10.01.48

CleanShot_2020-10-28_at_10.05.08

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

N/A

Closes #1029 (closed)

Edited by Jeremy Elder

Merge request reports