Skip to content

Include link button in gl-button styles

Jeremy Elder requested to merge remove-link-secondary-btn-style into master

What does this MR do?

Currently, the .btn-link button isn’t paired with the .gl-button class, like other buttons are, and styles from the Bootstrap npm package appear to be impacting the appearance of the button, especially when paired with the .btn-secondary class that can be added from the knobs in Storybook.

State Before After
rest CleanShot_2020-07-26_at_21.37.47_2x CleanShot_2020-07-26_at_21.39.43_2x
:hover CleanShot_2020-07-26_at_21.38.04_2x CleanShot_2020-07-26_at_21.40.15_2x
:focus CleanShot_2020-07-26_at_21.38.17_2x CleanShot_2020-07-26_at_21.40.27_2x
:active:focus CleanShot_2020-07-26_at_21.38.36_2x CleanShot_2020-07-26_at_21.40.39_2x

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Jeremy Elder

Merge request reports