Skip to content

Remove hardcoded aria-hidden

Jeremy Elder requested to merge jeldergl-master-patch-02646 into master

What does this MR do?

This removes the hardcoded aria-hidden="true" from the spinner. Currently, this negates the aria-label. When the spinner is visible, the label should be available to screen readers.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Jeremy Elder

Merge request reports