Skip to content

Remove the session duration information from the output of `2fa_verify` command

Manoj M J requested to merge 504-remove-the-session-duration-information-from-the-output-of-2fa_verify-command into main

For #504 (closed)

Background

Currently, gitlab-shell outputs

OTP validation successful. Git operations are allowed for the next 15 minutes.

when OTP validation is successful with the 2fa_verify command. (Introduced in !440 (merged))

With gitlab#296669 (closed), our plan is to allow admins to set any value as the session duration for git operations when 2FA is enabled.

This means that session duration can be set to less than or more than 15 minutes and hence the output of gitlab shell saying Git operations are allowed for the next 15 minutes. no longer holds true, if the value is not set to 15.

And hence, it is necessary to remove this information from the output of gitlab-shell.

The new proposed alternative is a simple OTP validation successful. Git operations are now allowed. as the output of gitlab-shell when OTP validation is successful.

This change makes changes to the wording only, and there is no code change involved.

GitLab changes

The MR for introducing customizable session timeouts for git operations when 2FA is enabled: gitlab!52769 (merged)

Edited by Ash McKenzie

Merge request reports