Loading
Commits on Source 41
-
Mark Florian authored
-
Mark Florian authored
Changelog entries now include a link to the originating merge request instead of the shortened hash of the commit that added the changeset. The author is also mentioned. Part of gitlab-org/gitlab-services/design.gitlab.com#2884.
-
Mark Florian authored
-
Mark Florian authored
-
Mark Florian authored
-
🤖 GitLab Bot 🤖 authored
-
Mark Florian authored
The scheduled pipeline will define `IS_PUBLISHING_PIPELINE=true` as well, in case we ever want other scheduled pipelines for other things. Later commits will ensure that the scheduled publishing pipeline is very lightweight. The idea is that jobs that test for correctness will run on merge requests, merge trains and merges in to `main`. That is: `main` shouldn't be able to be broken, because broken changes cannot be merged. So, we don't need to check for correctness in the scheduled publishing pipeline, since the branch must already be correct. One reason for making the publishing pipeline as lightweight as possible is to avoid a race condition. Consider these scenarios: 1. The current tip of `main`, commit A, has a changeset that means a package is ready to be published. 2. A scheduled publishing pipeline starts on commit A. 3. A merge request merges into `main`, advancing `main` to commit B. 4. The scheduled publishing pipeline tries to push to `main`, and fails, because `main` has advanced. This scenario was already possible before, if two merge requests merged at nearly the same time. The `publish_npm_packages` jobs would then race.
-
Mark Florian authored
Do this by only running jobs on the `main` branch if they are from `push` pipeline sources (i.e., merges into `main`).
-
Mark Florian authored
It only makes sense running these jobs in pipelines that introduce changes, i.e., in merge requests, and merge trains (because merged results can change things). Running these on `main` is a waste of time if they ran in merge trains.
-
Mark Florian authored
This also updates the code comment above the `publish_npm_packages` job accordingly.
-
Monica Galletto authored
-
Pedro Moreira da Silva authored
Feat(BrandPromptlings): adding colors and fixed light source on pngs See merge request gitlab-org/gitlab-services/design.gitlab.com!5833 Merged-by:
Pedro Moreira da Silva <hi@pedroms.com> Approved-by:
Tina Hsu <hhsu@gitlab.com> Approved-by:
Pedro Moreira da Silva <hi@pedroms.com> Reviewed-by:
Pedro Moreira da Silva <hi@pedroms.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Monica Galletto <mgalletto@gitlab.com>
-
🤖 GitLab Bot 🤖 authored
-
🤖 GitLab Bot 🤖 authored
-
Scott de Jonge authored
Update dependency fuse.js to ^7.3.0 See merge request gitlab-org/gitlab-services/design.gitlab.com!5816 Merged-by:
Scott de Jonge <sdejonge@gitlab.com> Approved-by:
Scott de Jonge <sdejonge@gitlab.com> Co-authored-by:
GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
Scott de Jonge authored
-
Thomas Hutterer authored
Add fuse.js to transpile nuxt build config See merge request gitlab-org/gitlab-services/design.gitlab.com!5842 Merged-by:
Thomas Hutterer <thutterer@gitlab.com> Approved-by:
Thomas Hutterer <thutterer@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Scott de Jonge <sdejonge@gitlab.com>
-
Mark Florian authored
Only running on `push` events meant that pipelines created with the web UI (e.g., to retry after a transient failure) wouldn't run these jobs, which probably isn't what we want. The only pipeline source we definitely don't want these jobs to run on is `schedule`, since that's reserved for very particular jobs only (e.g., package publishing). I did consider using an allowlist approach, e.g.: ``` $CI_PIPELINE_SOURCE =~ /^(push|web)$/ ``` but decided that I only knew that the jobs shouldn't run on a scheduled pipeline, so that's how it should be written. There could be legitimate reasons for, e.g., an `api` sourced pipeline to run all these jobs. See https://docs.gitlab.com/ci/jobs/job_rules/#ci_pipeline_source-predefined-variable for the values that `CI_PIPELINE_SOURCE` can take. See https://docs.gitlab.com/ci/jobs/job_rules/#compare-a-variable-to-a-regular-expression for the expression syntax.
-
Thomas Hutterer authored
Publish packages with dedicated scheduled pipeline See merge request gitlab-org/gitlab-services/design.gitlab.com!5838 Merged-by:
Thomas Hutterer <thutterer@gitlab.com> Approved-by:
Thomas Hutterer <thutterer@gitlab.com> Reviewed-by:
Thomas Hutterer <thutterer@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Mark Florian <mflorian@gitlab.com> -
Mark Florian authored
The original link was added in gitlab-org/gitlab-services/design.gitlab.com!4671, but the target content was moved in gitlab-org/gitlab-services/design.gitlab.com!5356. Ideally our `check_links` CI job would have caught this. Fortunately, it looks like recent versions of `linkinator` have a `--check-fragments` option. We should upgrade and enable that. See https://github.com/JustinBeckwith/linkinator/blob/3b8609d5b972478900c7d1f8372ffe5571e66210/CHANGELOG.md.
-
Mark Florian authored
Update dependency cypress to v15.13.1 See merge request gitlab-org/gitlab-services/design.gitlab.com!5839 Merged-by:
Mark Florian <mflorian@gitlab.com>
Approved-by:
Enrique Alcántara <ealcantara@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
Thomas Hutterer authored
Enhance changelog format See merge request gitlab-org/gitlab-services/design.gitlab.com!5793 Merged-by:
Thomas Hutterer <thutterer@gitlab.com> Approved-by:
Thomas Hutterer <thutterer@gitlab.com> Reviewed-by:
Mark Florian <mflorian@gitlab.com>
Reviewed-by: Thomas Hutterer <thutterer@gitlab.com> Reviewed-by:
Scott de Jonge <sdejonge@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Mark Florian <mflorian@gitlab.com> -
Mark Florian authored
The scheduled pipeline [failed](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/pipelines/2449427949) with: > 'ui:screenshot_collector' job needs 'ui:visual 1/2' job, but > 'ui:visual 1/2' does not exist in the pipeline. This might be because > of the only, except, or rules keywords. To need a job that sometimes > does not exist in the pipeline, use needs:optional. > 'ui:screenshot_collector' job needs 'ui:visual 2/2' job, but > 'ui:visual 2/2' does not exist in the pipeline. This might be because > of the only, except, or rules keywords. To need a job that sometimes > does not exist in the pipeline, use needs:optional. Which means the `packages/gitlab-ui/.gitlab-ci.yml` file was incorrectly included. Though the `is-default-branch` condition added in gitlab-org/gitlab-services/design.gitlab.com!5838 evaluates to `false` if the pipeline source is `schedule`, that just means the next rule is checked. See https://docs.gitlab.com/ci/yaml/#rulesif. The last rule only specifies `changes`, which: > when there is no Git push event, rules: changes always evaluates to > true and the job always runs So, these `packages/*/.gitlab-ci.yml` files were *always* being included in scheduled pipelines. The fix is to explicitly exclude them with `when: never`. This also adds `if` to the `changes` rule, to make it explicitly only for merge request events (merge requests, merge trains).
-
Savas Vedova authored
Update dependency postcss to v8.5.9 See merge request gitlab-org/gitlab-services/design.gitlab.com!5840 Merged-by:
Savas Vedova <svedova@gitlab.com>
Approved-by:
Savas Vedova <svedova@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
Scott de Jonge authored
Fix broken link See merge request gitlab-org/gitlab-services/design.gitlab.com!5843 Merged-by:
Scott de Jonge <sdejonge@gitlab.com> Approved-by:
Scott de Jonge <sdejonge@gitlab.com> Co-authored-by:
Mark Florian <mflorian@gitlab.com> -
Scott de Jonge authored
Update Figma example environment variables to clarify relationship for design token syncing and code connect API keys
-
Scott de Jonge authored
-
Scott de Jonge authored
Update Figma environment variable names See merge request gitlab-org/gitlab-services/design.gitlab.com!5841 Merged-by:
Scott de Jonge <sdejonge@gitlab.com> Approved-by:
Dan MH <dmizzi-harris@gitlab.com> Approved-by:
Vanessa Otto <votto@gitlab.com> Reviewed-by:
Scott de Jonge <sdejonge@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com>
-
Jeremy Elder authored
-
Dan MH authored
Checklist updates See merge request gitlab-org/gitlab-services/design.gitlab.com!5848 Merged-by:
Dan MH <dmizzi-harris@gitlab.com> Approved-by:
Adam Ferch <aferch@gitlab.com> Approved-by:
Dan MH <dmizzi-harris@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Jeremy Elder <jelder@gitlab.com>
-
Jeremy Elder authored
-
Dan MH authored
Resolve "Create 18.11 UI kit release notes" See merge request gitlab-org/gitlab-services/design.gitlab.com!5846 Merged-by:
Dan MH <dmizzi-harris@gitlab.com> Approved-by:
Dan MH <dmizzi-harris@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Jeremy Elder <jelder@gitlab.com>
-
Thomas Hutterer authored
Fix scheduled pipeline See merge request gitlab-org/gitlab-services/design.gitlab.com!5844 Merged-by:
Thomas Hutterer <thutterer@gitlab.com> Approved-by:
Thomas Hutterer <thutterer@gitlab.com> Co-authored-by:
Mark Florian <mflorian@gitlab.com> -
🤖 GitLab Bot 🤖 authored
-
Jeremy Elder authored
-
Dan MH authored
Minor release fixes See merge request gitlab-org/gitlab-services/design.gitlab.com!5850 Merged-by:
Dan MH <dmizzi-harris@gitlab.com> Approved-by:
Dan MH <dmizzi-harris@gitlab.com> Co-authored-by:
Jeremy Elder <jelder@gitlab.com>
-
Jeremy Elder authored
-
Jeremy Elder authored
18.11 UIK file backup See merge request gitlab-org/gitlab-services/design.gitlab.com!5847 Merged-by:
Jeremy Elder <jelder@gitlab.com> Approved-by:
Dan MH <dmizzi-harris@gitlab.com>
-
Dan MH authored
-
Scott de Jonge authored
Use overflow-x clip instead of overflow hidden for truncation See merge request gitlab-org/gitlab-services/design.gitlab.com!5849 Merged-by:
Scott de Jonge <sdejonge@gitlab.com> Approved-by:
Chad Lavimoniere <clavimoniere@gitlab.com> Approved-by:
Scott de Jonge <sdejonge@gitlab.com> Reviewed-by:
Scott de Jonge <sdejonge@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Dan MH <dmizzi-harris@gitlab.com> Co-authored-by:
GitLab Bot <gitlab-bot@gitlab.com>
-
🤖 GitLab Bot 🤖 authored