Use overflow-x clip instead of overflow hidden for truncation

What does this MR do?

gl-truncate and related truncation utilities use overflow: hidden, which clips the bottom of text. Descenders (g, y, p, q, j), box-shadows, and focus rings get cut off.

Solution

Replace overflow: hidden with overflow-x: clip; overflow-y: visible across all truncation utilities and components.

Why overflow-x: clip instead of overflow-x: hidden?

The CSS spec computes overflow-y: visible to auto when paired with overflow-x: hidden, which can create an unwanted scrollbar. When paired with overflow-x: clip, overflow-y: visible stays as visible. This gives us horizontal clipping with ellipsis while letting vertical content (descenders, shadows) render naturally.

We avoid overflow-clip-margin because it is not supported in Safari.

Why min-width: 0?

overflow: hidden creates a block formatting context (BFC), which allows flex children to shrink below their content width. overflow: clip does not create a BFC, so flex children default to min-width: auto and refuse to shrink. Adding min-width: 0 restores the shrinking behaviour without relying on the BFC side-effect.

Screenshots or screen recordings

Before After
storyshots-spec-js-image-storyshots-base-attribute-list-custom-classes-1-snap-1.png storyshots-spec-js-image-storyshots-base-attribute-list-custom-classes-1-snap.png
storyshots-spec-js-image-storyshots-base-dropdown-collapsible-listbox-with-long-content-1-snap.png storyshots-spec-js-image-storyshots-base-dropdown-collapsible-listbox-with-long-content-1-snap-1.png

Integrations

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • The “What does this MR do?” section in the MR description is filled out, explaining the reasons for and scope of the proposed changes, per “Say why not just what”.
    • For example, if the MR is focused on usage guidelines, addressing accessibility challenges could be added in a separate MR.
  • Relevant label(s) are applied to the MR.
  • The MR is added to a milestone.
  • Added the ~"component:*" label(s) if applicable.
  • A changeset is added when this MR will do a patch, minor, or major update. More information can be found in doc/publishing-packages.md.

Components

  • GitLab UI's contributing guidelines.
  • If the MR changes a component's API, integration MR(s) have been opened (see integrations above).

Documentation

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Dan MH

Merge request reports

Loading