Skip to content

Draft: Add feedback border design tokens

What does this MR do?

  • Adds feedback.*.border.color design tokens for:
    • strong
    • neutral
    • info
    • success
    • warning
    • danger
  • Update examples to include border
  • Update documentation for details on when a border is necessary

This is in support of #3162 and related issues where border colors are applied with constant values that could be replaced with semantics that aren't covered by action and control border design tokens.

Proposal

  • Use border colors that are darker (light mode) or brighter (dark mode) than the default border so that feedback borders stand out.
  • Use a more noticeable border for danger that matches the visual "loudness" of the feedback intent. For example, an error is visually louder than a success message. This is also for parity with control.border.color.error.
Visual with annotations…

Feedback border

Integrations

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • The “What does this MR do?” section in the MR description is filled out, explaining the reasons for and scope of the proposed changes, per “Say why not just what”.
    • For example, if the MR is focused on usage guidelines, addressing accessibility challenges could be added in a separate MR.
  • Relevant label(s) are applied to the MR.
  • The MR is added to a milestone.
  • Added the ~"component:*" label(s) if applicable.
  • A changeset is added when this MR will do a patch, minor, or major update. More information can be found in doc/publishing-packages.md.

Components

Documentation

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to #3162

Edited by Jeremy Elder

Merge request reports

Loading