Skip to content

feat(Buttons): Clarify icon use in default dropdown button

Jeremy Elder requested to merge jeldergl-master-patch-27592 into master

In gitlab-org/gitlab-ui#912 (closed) it was determined that for the default dropdown there should NOT be an icon to the left of the text label.

This is to prevent:

  • The icon from conflicting with the chevron-down icon on the right.
  • The icon from not changing dynamically when the dropdown option has been changed. For example, the disabled variant below should have notifications-off.svg if it were dynamic.

Note: examples pulled from buttons that have not been migrated to the new button yet.

Don’t × Do √
CleanShot_2020-08-05_at_10.19.36_2x CleanShot_2020-08-05_at_10.20.22_2x
CleanShot_2020-08-05_at_10.19.22_2x CleanShot_2020-08-05_at_10.20.44_2x

Closes gitlab-org/gitlab-ui#912 (closed)

Edited by Jeremy Elder

Merge request reports

Loading