Skip to content
  1. Apr 20, 2021
  2. Apr 08, 2021
  3. Apr 07, 2021
  4. Apr 06, 2021
  5. Apr 05, 2021
  6. Apr 02, 2021
  7. Apr 01, 2021
  8. Mar 31, 2021
  9. Mar 29, 2021
  10. Mar 26, 2021
    • Elliot Rushton's avatar
      Merge branch 'poffey21-master-patch-05916' into 'master' · de3bbe0a
      Elliot Rushton authored
      Update warning message URL for DockerHub
      
      See merge request !2844
      de3bbe0a
    • Steve Xuereb's avatar
      Remove docker-machine provision on creation failure · d2f2f00c
      Steve Xuereb authored
      In
      #27613 (comment 522938477)
      we see machines failing to create on the cloud provider, but it fails
      for rate limit reasons or anything else. This leads to a split-brain issue where we have state of a machine "created" in `docker-machine`
      state but the machine is nonexistent/inaccessible to the cloud provider.
      
      If the creation fails `docker-machine provision` runs on a machine that
      doesn't exist which wastes API requests, and time trying to wait for SSH
      to be available on a machine. The `docker-machine provision` tries to
      re-provision an existing machine, but if creation fails that means that
      the machine doesn't exist.
      
      Instead of retrying to create/provision the machine with the same details
      fail fast, remove the machine and try to create a new one with details.
      This should result in much quicker recovery when we reach the API rate
      limits on the cloud provider and also job queues because the machine
      would be available sooner rather than waiting for `docker-machine
      provision` to be available.
      
      To enable this fail fast functionality you have to enable
      `FF_SKIP_DOCKER_MACHINE_PROVISION_ON_CREATION_FAILURE` feature flag
      inside of the `config.toml`
      
      reference #27613
      d2f2f00c
    • Tim Poffenbarger's avatar
      361645ef
  11. Mar 25, 2021
    • Tomasz Maczukin's avatar
      Merge branch 'feature-flags-configuraiton' into 'master' · fea697cd
      Tomasz Maczukin authored
      Add feature flags in config.toml
      
      See merge request !2811
      fea697cd
    • Steve Xuereb's avatar
      feat(ff): set feature flag in config.toml · 6996aecc
      Steve Xuereb authored
      What:
      Allow user to set a feature flag inside of the config.toml with
      `[runners.feature_flags]` which aren't overridable able by an job
      variables.
      
      Why:
      In !2805 we
      want to change how `docker+machine` executor creates machines and we
      want to roll this out behind a feature flag. At the moment users can
      only specify a feature flag as a job variable, which won't work in this
      case because a machine is created before a job exists so there is no way
      we can set this.
      
      part of #27613
      6996aecc
    • Steve Xuereb's avatar
      refactor(ff): change default type to bool · 94948c70
      Steve Xuereb authored
      Having a bool as a string makes it hard when you want to check if
      pragmatically. It's easier to transform a bool to a string then vice
      versa.
      94948c70
  12. Mar 24, 2021
Loading