Windows CI doesn't fail on test build failures
Overview
Looking at https://gitlab.com/gitlab-org/gitlab-runner/-/jobs/1103436331 we see the following build failed error:
ok gitlab.com/gitlab-org/gitlab-runner/executors/docker/internal/user 1.540s
--- Starting part 0 of go tests of 'gitlab.com/gitlab-org/gitlab-runner/executors/docker/internal/volumes' package:
FAIL gitlab.com/gitlab-org/gitlab-runner/executors/docker/internal/volumes [build failed]
FAIL
--- Starting part 1 of go tests of 'gitlab.com/gitlab-org/gitlab-runner/executors/docker/internal/volumes' package:
# gitlab.com/gitlab-org/gitlab-runner/executors/docker/internal/volumes_test [gitlab.com/gitlab-org/gitlab-runner/executors/docker/internal/volumes.test]
executors\docker\internal\volumes\manager_integration_windows_test.go:9:6: TestCreateVolumesLabels redeclared in this block
previous declaration at executors\docker\internal\volumes\manager_integration_unix_test.go:9:33
FAIL gitlab.com/gitlab-org/gitlab-runner/executors/docker/internal/volumes [build failed]
FAIL
The job failed however it's allowed to fail, we usually catch failures like these in check windows 1809 panic test failures
/ check windows 1809 test failures
. It seems none of these jobs are checking for build failure.