Add note about empty runner-registration-token
What does this MR do?
We have multiple users trying to solve a problem when their secret storage solution doesn't allow them to set empty string as a value for secret.
This isn't actually a problem, they just need to use new token architecture(we've already updated docs to it), and they can set anything for runner-registration-token
, runner-token
will take precedence anyway.
This MR clarifies the docs
What are the relevant issue numbers?
Merge request reports
Activity
assigned to @vshushlin
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer No reviewer available Joe Burnett (
@josephburnett
) (UTC-7, 9 hours behind@vshushlin
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Fiona Neill
changed milestone to %16.3
added devopsverify sectionci labels
mentioned in merge request gitlab!128787 (merged)
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@vshushlin - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
mentioned in issue gitlab-org/charts/gitlab-runner#462 (closed)
- Resolved by Fiona Neill
added maintenancerefactor typemaintenance labels
changed milestone to %16.4
added missed:16.3 label
Hi
@fneill
,GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.
This message was generated automatically. You're welcome to improve it.
added Technical Writing label
enabled automatic add to merge train when the pipeline for 7930bdae succeeds
added docsimprovement label
mentioned in commit 0b0b0364
mentioned in merge request !5054 (merged)
mentioned in issue #38236