Skip to content

Improve build logging testing

Arran Walker requested to merge ajwalker/build-logger-tests into master

What does this MR do?

Improves testing of the build logging package by ensuring that the printers do in fact print.

Why was this MR needed?

For incremental improvement to the tracing performance. In a later MR, the secret tests performed in build_logging_test.go will be removed, and therefore there is no other additional test that also checks output. This adds those specific tests.

What's the best way to test this MR?

Run the tests.

All printer functions have a if entry == nil check that I'm pretty sure is redundant. I don't know whether we want to remove that as part of this change?

What are the relevant issue numbers?

#27073 (closed)

Edited by Arran Walker

Merge request reports