Skip to content

Refactor Helper Image package to work with Kubernetes

Steve Xuereb requested to merge 3896-refactor-helper-image-package into master

What does this MR do?

Refactor Helper Image package to work with Kubernetes

Why was this MR needed?

The helper image is being used for both kubernetes and docker executor. But the code does not represent this, instead, it duplicates the logic, such as creating the Linux tag and the name of the image.

Refactor the helperimage package so that it can be used for both, by removing specific structs from the docker API, by defining helperimage own Config struct.

This refactoring was needed because of &535 (closed) we need to somehow change the helper image command specified in common/container.go depending on the OS that is used and that is used between docker and kubernetes. This can be seen in a WIP MR !1243 (merged)

Are there points in the code the reviewer needs to double check?

Make sure !1305 (closed) is merged before hand

Does this MR meet the acceptance criteria?

  • [-] Documentation created/updated
  • [-] Added tests for this feature/bug
  • [-] In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Merge request using this refactor !1243 (merged)

Reference #3896 (closed)

Merge request reports