Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gitlab-runner
gitlab-runner
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2,107
    • Issues 2,107
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 205
    • Merge requests 205
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • gitlab-runnergitlab-runner
  • Issues
  • #3896

Closed
Open
Created Jan 15, 2019 by Steve Azzopardi@steveazzMaintainer

Add powershell support for docker executor

Description

⚠ Blocked by: #3755 (closed), #3895 (closed) ⚠

When we stat supporting multiple helper images for windows, we need to update the init() so that it can use the windows version.

Proposal

  1. Switch the base image for helper image to server core.
    • Yes, this will make the helper image 4.5GB but the user will already have the large layers locally anyways because their jobs are most likely using server core (as explained in #3896 (comment 153848415)
    • The size of the container image is not that big of an issue since we do not support loading the image from a local archive as we do for Linux
  2. By switching to servercore we can use PowerShell 5 for now, making the first iteration even smaller, since we don't have to support PowerShell 6 and as described above we don't have to handle switching BOM on and off depending on what PowerShell version we use.

For now we are only going to support PowerShell 5 when using the windows docker executor.

We can do this in multiple ways.

1. We can use the shell configuration form the [[runner]] section 1. We can detect the runtime of the runner with runtime.GOOS

Links to related issues and merge requests / references

Blocked by: #3755 (closed) Epic: &535 (closed)

Edited Apr 11, 2019 by Steve Azzopardi
Assignee
Assign to
11.11
Milestone
11.11 (Past due)
Assign milestone
Time tracking