Skip to content

Resolve "`make verify` Job Failed #327768208"

Vladimir Shushlin requested to merge 263-make-verify-job-failed-327768208 into master

For some reason long awk command makes it crash with a segmentation fault error.

I tested this by replacing $(allfiles) in "Please run ./bin/goimports -w -local $(IMPORT_PATH) -l $(allfiles)" with strings of various length, and it fails on longer strings.

Consider jobs: https://gitlab.com/gitlab-org/gitlab-pages/-/jobs/328005567 https://gitlab.com/gitlab-org/gitlab-pages/-/jobs/328020432

The only difference is long aaaaaa... in awk command.

I haven't yet figured out the source of the problem, so just copypasted the approach from workhorse - extracted a separate script which uses if in shell script and echo to print the suggestion.

Workhorse implementation: https://gitlab.com/gitlab-org/gitlab-workhorse/blob/master/Makefile#L128 https://gitlab.com/gitlab-org/gitlab-workhorse/blob/master/_support/validate-formatting.sh

The failed output stayed the same:

➜  gitlab-pages git:(263-make-verify-job-failed-327768208) ✗ make verify
gitlab.com/gitlab-org/gitlab-pages gitlab.com/gitlab-org/gitlab-pages/internal gitlab.com/gitlab-org/gitlab-pages/internal/acme gitlab.com/gitlab-org/gitlab-pages/internal/artifact gitlab.com/gitlab-org/gitlab-pages/internal/auth gitlab.com/gitlab-org/gitlab-pages/internal/config gitlab.com/gitlab-org/gitlab-pages/internal/deprecatedargs gitlab.com/gitlab-org/gitlab-pages/internal/domain gitlab.com/gitlab-org/gitlab-pages/internal/fixture gitlab.com/gitlab-org/gitlab-pages/internal/handlers gitlab.com/gitlab-org/gitlab-pages/internal/host gitlab.com/gitlab-org/gitlab-pages/internal/httperrors gitlab.com/gitlab-org/gitlab-pages/internal/httptransport gitlab.com/gitlab-org/gitlab-pages/internal/httputil gitlab.com/gitlab-org/gitlab-pages/internal/jail gitlab.com/gitlab-org/gitlab-pages/internal/logging gitlab.com/gitlab-org/gitlab-pages/internal/mocks gitlab.com/gitlab-org/gitlab-pages/internal/netutil gitlab.com/gitlab-org/gitlab-pages/internal/request gitlab.com/gitlab-org/gitlab-pages/internal/serving gitlab.com/gitlab-org/gitlab-pages/internal/serving/disk gitlab.com/gitlab-org/gitlab-pages/internal/source gitlab.com/gitlab-org/gitlab-pages/internal/source/disk gitlab.com/gitlab-org/gitlab-pages/internal/testhelpers gitlab.com/gitlab-org/gitlab-pages/internal/tlsconfig gitlab.com/gitlab-org/gitlab-pages/metrics
Please run ./bin/goimports -w -local gitlab.com/gitlab-org/gitlab-pages -l ./metrics/metrics.go ./server.go ./internal/serving/serving.go ./internal/serving/handler.go ./internal/serving/lookup_path.go ./internal/serving/disk/serving.go ./internal/serving/disk/reader.go ./internal/serving/disk/helpers_test.go ./internal/serving/disk/helpers.go ./internal/serving/disk/errors.go ./internal/httperrors/httperrors.go ./internal/httperrors/httperrors_test.go ./internal/host/host_test.go ./internal/host/host.go ./internal/fixture/fixtures.go ./internal/config/config.go ./internal/config/config_test.go ./internal/acme/acme_test.go ./internal/acme/acme.go ./internal/auth/auth_test.go ./internal/auth/auth.go ./internal/httptransport/transport.go ./internal/source/domains.go ./internal/source/disk/custom.go ./internal/source/disk/config.go ./internal/source/disk/domain_test.go ./internal/source/disk/group_test.go ./internal/source/disk/group.go ./internal/source/disk/map_test.go ./internal/source/disk/map.go ./internal/source/disk/config_test.go ./internal/testhelpers/testhelpers.go ./internal/interface.go ./internal/deprecatedargs/deprecatedargs.go ./internal/deprecatedargs/deprecatedargs_test.go ./internal/tlsconfig/tlsconfig_go1_12_test.go ./internal/tlsconfig/tlsconfig.go ./internal/tlsconfig/tlsconfig_test.go ./internal/tlsconfig/tlsconfig_go1_12.go ./internal/jail/mount_linux.go ./internal/jail/jail.go ./internal/jail/mount_not_supported.go ./internal/jail/jail_test.go ./internal/request/request_test.go ./internal/request/request.go ./internal/artifact/artifact.go ./internal/artifact/artifact_test.go ./internal/netutil/shared_limit_listener.go ./internal/domain/domain.go ./internal/domain/domain_test.go ./internal/domain/resolver.go ./internal/handlers/handlers_test.go ./internal/handlers/handlers.go ./internal/logging/logging.go ./internal/logging/logging_test.go ./tools.go ./app.go ./multi_string_flag.go ./helpers_test.go ./multi_string_flag_test.go ./app_config.go ./daemon.go ./config_test.go ./helpers.go ./acceptance_test.go ./main.go
./main.go

Closes #263 (closed)

Edited by Vladimir Shushlin

Merge request reports