Allow auth http.Client timeout to be configurable
Currently the auth
package has a hardcoded timeout of 5s which might not be enough for some setups.
Proposal:
-
Introduce a
auth-timeout
flag to Pages: !687 (merged) - Add the flag to Omnibus: omnibus-gitlab!7268 (merged)
- Add the flag to Helm charts.: gitlab-org/charts/gitlab!3502 (merged)
- Add the setting to the pages admin docs: gitlab!137845 (merged)
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Jaime Martinez set weight to 3
set weight to 3
- Jaime Martinez added featureaddition label
added featureaddition label
- 🤖 GitLab Bot 🤖 added typefeature label
added typefeature label
- 🤖 GitLab Bot 🤖 added sectionops label
added sectionops label
- Contributor
- Contributor
Hi @jaime I am sorry if I am boring too much but I have an assignment for school homework. Therefore, If you reply to my request as soon as possible, I would be glad.
Edited by Osman İlge Ünaldı Collapse replies - Author Maintainer
@Osmanilge thanks for volunteering! Feel free to submit an MR and ping one of the reviewers in https://about.gitlab.com/handbook/engineering/projects/#gitlab-pages when you are ready
Please follow the instructions listed in https://gitlab.com/gitlab-org/gitlab-pages/-/blob/master/doc/development.md#getting-started-with-development to setup your development environment.
Pages depends on the GitLab API. I would recommend you to setup a GDK instance locally as well.
Once you have that, you should be able to build and run GitLab Pages.
- Contributor
@jaime thank you very much could you assign me. so thanks again. I have successfully built the binaries.
Edited by Osman İlge Ünaldı 1 Collapse replies - Author Maintainer
Great!
- Jaime Martinez changed milestone to %14.8
changed milestone to %14.8
- Jaime Martinez assigned to @Osmanilge
assigned to @Osmanilge
- Contributor
@jaime could you help me about instructions for issue. I searched a little bit and I found where I will change but my go acknowledge is not enough for understand why should I do? May you explain more?
Edited by Osman İlge Ünaldı - Contributor
@jaime Hi. I added the authTimeout flag to flags and I updated the config for authTimeout flag for now. Did I understand correctly?
Edited by Osman İlge Ünaldı Collapse replies - Author Maintainer
@Osmanilge have a look at the explanation in #688 (comment 818899034). This change is very similar so you should be able to follow most steps there.
It would also be easier to review a merge request so please open one when you are ready.
- Contributor
Hi @jaime I created a merge request. May you check the codes?
- Jaime Martinez mentioned in merge request !687 (merged)
mentioned in merge request !687 (merged)
- Nicole Williams removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Nicole Williams changed milestone to %14.9
changed milestone to %14.9
- Nicole Williams added Community contribution label
added Community contribution label
- Nicole Williams added devopscreate groupeditor [DEPRECATED] sectiondev labels and removed devopsrelease [DEPRECATED] grouprelease [DEPRECATED] sectionops labels
added devopscreate groupeditor [DEPRECATED] sectiondev labels and removed devopsrelease [DEPRECATED] grouprelease [DEPRECATED] sectionops labels
- 🤖 GitLab Bot 🤖 added quick win label and removed [deprecated] good for new contributors label
added quick win label and removed [deprecated] good for new contributors label
- 🤖 GitLab Bot 🤖 added groupknowledge label and removed groupeditor [DEPRECATED] label
added groupknowledge label and removed groupeditor [DEPRECATED] label