You need to sign in or sign up before continuing.
Comprehensive metrics testing
The following discussion from !213 (merged) should be addressed:
-
@grzesiek started a discussion: (+1 comment) I think that we should refactor this stuff to make it easier to write tests for metrics with mocks. But perhaps we should do that in a separate merge request since it would require a significant refactoring of this file. Thoughts @nick.thomas?
Right now, acceptance_test.go
checks a couple of prometheus counters, which is a great smoke test, but it would be nice to have unit tests for each individual metric as well. It's not easy to do that right now.