Fix a nasty transient failure happening is a subsequent spec

What does this MR do?

Explanation can be found at https://gitlab.com/gitlab-org/gitlab-ce/issues/34698#note_34276286.

What are the relevant issue numbers?

Closes #34698 (closed)

/cc @nick.thomas

@nick.thomas Do you think we still need !12661 (merged)?

mentioned in merge request !12361 (merged)

@rymai I fixed Rubocop offenses and arguments used in project_path, but I see an error when running wiki specs locally:

      Capybara::Poltergeist::JavascriptError:
        One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

        TypeError: undefined is not an object (evaluating 'options.domain')
        TypeError: undefined is not an object (evaluating 'options.domain')
            at undefined:107 in Jed
        Error: No URL provided.
        Error: No URL provided.
            at undefined:439 in Dropzone
            at :1464 in discover
            at :1746 in _autoDiscoverFunction
            at :1715 in init

assigned to @rymai

added 2 commits

• 320ad563 - Fix Rubocop offenses in gitaly client ref specs
• a9908342 - Fix project_path helper arguments in wiki specs

Compare with previous version

mentioned in merge request !12509 (merged)

Found a discussion on slack related to JS error https://gitlab.slack.com/archives/C02PF508L/p1499105159074001

10 examples, 0 failures

Let's MWPS this MR! Thank you @rymai

approved this merge request

assigned to @grzesiek

enabled an automatic merge when the pipeline for a9908342 succeeds

merged

mentioned in commit afd5c34d

mentioned in merge request !12661 (merged)