Fix stubbing attributes alongside cache_markdown_field

What does this MR do?

Regenerates the HTML for markdown fields if there is text in the markdown field and a blank string in the corresponding HTML field.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Previously, we'd only regenerate the HTML if the html field was nil. This turned out to break some specs when stubbing the relevant text fields, e.g., https://gitlab.com/gitlab-org/gitlab-ce/issues/34698#note_34263270

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes #34698 (closed)

mentioned in issue #34698 (closed)

/cc @DouweM

mentioned in merge request !12664 (merged)

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12664#note_34277707

@rymai I think we should merge this as well as !12664 (merged) - it will prevent this problem from showing up again on markdown fields other than application_settings. E.g., I think this will break at the moment, and it's not at all obvious why at the outset:

issue = create(:issue)
allow(issue).to receive(:title).and_return("**foo**")
text = markdown_field(issue, :title)

expect(text).to include('<b>foo</b>')

@nick.thomas Good point! Let's stay safe!

approved this merge request

changed milestone to %9.4

merged

mentioned in commit 7f381461