Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !9944

Ensure dots in project and group ID are allowed in the API endpoints

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rémy Coutable requested to merge 27988-fix-transient-failure-in-commits-api into master Mar 14, 2017
  • Overview 13
  • Commits 2
  • Pipelines 4
  • Changes 62

What does this MR do?

The issue is well described here: https://gitlab.com/gitlab-org/gitlab-ce/issues/27988#note_25342521

This merge request adds a requirement for the :id (or :project_id) param in all the endpoints namespaced under /projects or /groups. Here, :id is a project (or group) ID or full path, which can contain a dot (.). Adding this requirement solves the issue where the route would return a 404.

We're already using this similar "hack" for branches' names in various API endpoints (e.g. https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/api/branches.rb#L32).

Closes #27988 (closed) /cc @geoandri

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 27988-fix-transient-failure-in-commits-api