Skip to content
Snippets Groups Projects

Added filtered search bar to issue boards

Merged Phil Hughes requested to merge issue-boards-new-search-bar into master
All threads resolved!

Added the filtered search bar onto the issue boards page. This does not add it into the issues modal, that will be done in a different merge request.

Tweaked the filtered search to allow for the search to be performed async like issue boards currently does. This means adding the updated parameter string into the issue boards store & then allowing the Vue code to react to it correctly. Also had to tweak this slightly to stop Droplab getting destroyed when pressing enter, instead it just stops propagation when handled async.

Tweaked the clear button as well so that when clicking it it now resets the filter & sends new AJAX requests to get the updated data.

Screen_Shot_2017-03-07_at_15.50.08

Closes #28312 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Filipa Lacerda
  • Filipa Lacerda
  • Filipa Lacerda
  • Filipa Lacerda
  • Filipa Lacerda
  • Looking good :muscle: just left some minor comments ;)

  • Phil Hughes resolved all discussions

    resolved all discussions

  • Phil Hughes added 1 commit

    added 1 commit

    • 7eabb7a9 - Use reduce instead of a forEach

    Compare with previous version

  • Phil Hughes unmarked as a Work In Progress

    unmarked as a Work In Progress

  • assigned to @filipa

  • Filipa Lacerda
  • Filipa Lacerda
  • Filipa Lacerda
  • Filipa Lacerda
  • @iamphill just 1 comment - the eventhub one.

    LGTM :sparkles:

  • Phil Hughes resolved all discussions

    resolved all discussions

  • Phil Hughes added 1 commit

    added 1 commit

    • c7cecae6 - added eventhub to emit update tokens event

    Compare with previous version

  • Author Developer

    @filipa made the change :thumbsup:

    & also pushed to EE branch https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1397

  • assigned to @filipa

  • Filipa Lacerda
  • Thank you @iamphill LGTM! Test it locally and did not find any problem :rocket:

  • Filipa Lacerda Approved this merge request

    Approved this merge request

  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • Filipa Lacerda mentioned in commit 0046ffc0

    mentioned in commit 0046ffc0

  • Author Developer

    @filipa Thanks!

    Can you also check & merge the EE version https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1397? Has all the changes you suggested with a slight change in locking the milestone filter when a board has a milestone.

  • Phil Hughes resolved all discussions

    resolved all discussions

  • mentioned in issue #30503 (closed)

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • Please register or sign in to reply
    Loading