Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !9546
Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Merged
Created Feb 27, 2017 by Alexis Reigel@koffeinfreiContributor8 of 9 tasks completed8/9 tasks
  • Review changes

  • Download
  • Email patches
  • Plain diff

GPG signed commits

  • Overview 395
  • Commits 96
  • Pipelines 66
  • Changes 78

What does this MR do?

  1. Shows gpg signed commits (excl. tags)
  2. If the gpg key is verified (= the gpg was added to GitLab and the user's email matches the key's email) a "Verified" batch is displayed
  3. If the gpg key is not verified or does not exist on GitLab an "Unverified" batch is displayed
  4. If the commit is not signed, the behaviour is unchanged
  5. Allows the user to add gpg keys to his profile

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Git allows to signed commits. This PR enables displaying those commits.

The development of this MR is sponsored by @siemens (/cc @bufferoverflow).

Screenshots (if relevant)

Commits list:

Commits___signed_commits___nannie_bernhard___gitlab_test___GitLab_3_

Commit details:

signed_commit_by_nannie_bernhard__0f44cd1d____Commits___nannie_bernhard___gitlab_test___GitLab

Badge popovers:

Commits___signed_commits___nannie_bernhard___gitlab_test___GitLab_5_

Commits___signed_commits___nannie_bernhard___gitlab_test___GitLab_4_

User settings > GPG key:

GPG_Keys___User_Settings___GitLab_2_

Does this MR meet the acceptance criteria?

  • Changelog entry added
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/20268.

Edited Jul 27, 2017 by Dmytro Zaporozhets (DZ)
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/gpg-signed-commits