Skip to content

Resolve "NameError: uninitialized constant ApplicationSetting::DEFAULTS"

Rémy Coutable requested to merge 27280-fix-unititalized-constant into master

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1124

What does this MR do?

I've implemented all the suggestions I made in https://gitlab.com/gitlab-org/gitlab-ce/issues/27280.

Are there points in the code the reviewer needs to double check?

I've chosen to rename Gitlab::Shell to Gitlab::Backend::Shell and Gitlab::ShellAdapter to Gitlab::Backend::ShellAdapter but we could also simply move the file to lib/. 🤷

Why was this MR needed?

Because of nasty things were happening with Rails auto-loading!

Closes #27280 (closed)

Merge request reports