Skip to content

Mark Commit persisted

Rémy Coutable requested to merge pmq20/gitlab-ce-psvr/persisted into master

Originally opened at !3780 (closed) by @pmq20.

What does this MR do?

Mark commit as persisted so that polymorphic_url of Rails could correctly generate a url for namespaced project commit actions. For specific reasons in which this is needed, cf, https://github.com/rails/rails/blob/v4.2.6/actionpack/lib/action_dispatch/routing/polymorphic_routes.rb#L298

Are there points in the code the reviewer needs to double check?

This is a global change to all Commit objects which might introduce reactions in other parts of the program.

Why was this MR needed?

This allows us to make use of polymorphic routes instead of using Kernel.send.

Does this MR meet the acceptance criteria?

Merge request reports