Skip to content

Make cycle_analytics_events_spec.rb side-effect free

Rémy Coutable requested to merge 26622-fix-transient-failure-in-cycle_analytics_events_spec into master

What does this MR do?

I was not able to reproduce the transient failure locally but I believe it happens when run in combination with other specs.

Basically querying for MergeRequest.order(...).first is a recipe for unpredictable specs since a merge request could be created for another project in the meantime, and we'd assert against a merge request IID that doesn't belong to the current project. I'm not 100% how this could happen since specs should always start with a clean state, but 🤷!

Closes #26622 (closed) /cc @jameslopez

Merge request reports