Skip to content

Remove Turbolinks

Bryce Johnson requested to merge 25624-anticipate-obstacles-to-removing-turbolinks into master

A note to reviewers:

Just pick a few files on the list, figure out what page the code is being run on, navigate there and click around. Then, edit this MR description with (@your-username - ✅ ) tacked to the end of the filename's task item. If there's something wrong, add a comment to the MR. Thanks for helping out!

JavaScript

  • app/assets/javascripts/admin.js (Turbolinks.visit) (@brycepj - ✅)
  • app/assets/javascripts/build.js (Turbolinks.visit) (@filipa - ✅ )
  • app/assets/javascripts/filtered_search/filtered_search_manager.js.es6 (Turbolinks.visit)
  • app/assets/javascripts/gl_dropdown.js (Turbolinks.visit)
  • app/assets/javascripts/issuable.js.es6 (Turbolinks.visit) (@brycepj - ✅ )
  • app/assets/javascripts/logo.js (Turbolinks.enableProgressBar) (@brycepj - ✅ )
  • app/assets/javascripts/project.js|102 col 15| Turbolinks.visit(action + '' + divider + '' + $form.serialize());
  • app/assets/javascripts/project_import.js|8 col 16| return Turbolinks.visit(location.href);
  • app/assets/javascripts/shortcuts.js|26 col 18| return Turbolinks.visit(findFileURL);
  • app/assets/javascripts/shortcuts_issuable.js|70 col 14| return Turbolinks.visit($editBtn.attr('href'));
  • app/assets/javascripts/tree.js|18 col 20| return Turbolinks.visit(path);
  • app/assets/javascripts/tree.js|60 col 20| return Turbolinks.visit(path);
  • app/assets/javascripts/todos.js.es6|38 col 9| Turbolinks.visit(this.action + '&' + $(this).serialize());
  • app/assets/javascripts/todos.js.es6|146 col 16| return Turbolinks.visit(url);
  • app/assets/javascripts/todos.js.es6|160 col 16| return Turbolinks.visit(todoLink);
  • app/assets/javascripts/vue_pagination/index.js.es6|23 col 11| Turbolinks.visit(?scope=${apiScope}&p=${pagenum}); (@filipa - ✅ )
  • app/assets/javascripts/vue_pipelines_index/pipelines.js.es6|39 col 9| Turbolinks.visit(?scope=${apiScope}&p=${pagenum}); (@filipa - ✅ )
  • app/views/shared/issuable/ filter.html.haml|94 col 5| Turbolinks.visit(this.action + '&' + $(this).serialize());
  • app/views/shared/issuable/search_bar.html.haml|126 col 5| Turbolinks.visit(this.action + '&' + $(this).serialize());
  • spec/javascripts/build_spec.js.es6|170 col 15| spyOn(Turbolinks, 'visit'); (@brycepj - ✅ )
  • spec/javascripts/build_spec.js.es6|180 col 16| expect(Turbolinks.visit).toHaveBeenCalledWith(BUILD_URL); (@brycepj - ✅ )
  • spec/javascripts/gl_dropdown_spec.js.es6|112 col 17| spyOn(Turbolinks, 'visit').and.stub(); (@brycepj - ✅ )
  • spec/javascripts/gl_dropdown_spec.js.es6|118 col 66| if (linkedLocation && linkedLocation !== '#') expect(Turbolinks.visit).toHaveBeenCalledWith(linkedLocation); (@brycepj - ✅ )
  • spec/javascripts/issuable_spec.js.es6|45 col 15| spyOn(Turbolinks, 'visit'); (@brycepj - ✅ ) (@brycepj - ✅ )
  • spec/javascripts/issuable_spec.js.es6|49 col 16| expect(Turbolinks.visit).toHaveBeenCalledWith(BASE_URL + DEFAULT_PARAMS); (@brycepj - ✅ )
  • spec/javascripts/issuable_spec.js.es6|53 col 15| spyOn(Turbolinks, 'visit'); (@brycepj - ✅ )
  • spec/javascripts/issuable_spec.js.es6|59 col 16| expect(Turbolinks.visit).toHaveBeenCalledWith(BASE_URL + params); (@brycepj - ✅ )
  • spec/javascripts/issuable_spec.js.es6|63 col 15| spyOn(Turbolinks, 'visit'); (@brycepj - ✅ )
  • spec/javascripts/issuable_spec.js.es6|70 col 16| expect(Turbolinks.visit).toHaveBeenCalledWith(BASE_URL + params); (@brycepj - ✅ )
  • spec/javascripts/issuable_spec.js.es6|77 col 16| expect(Turbolinks.visit).toHaveBeenCalledWith(BASE_URL + params); (@brycepj - ✅ )

Consider bigger changes that can happen (remove offs, and restructure files)

page:fetch

  • app/assets/javascripts/application.js (@brycepj - ✅ )
  • app/assets/javascripts/filtered_search/filtered_search_dropdown_manager.js.es6|12 col 34| document.addEventListener('page:fetch', this.cleanupWrapper);
  • app/assets/javascripts/filtered_search/filtered_search_dropdown_manager.js.es6|23 col 37| document.removeEventListener('page:fetch', this.cleanupWrapper);
  • app/assets/javascripts/filtered_search/filtered_search_manager.js.es6|18 col 36| document.addEventListener('page:fetch', this.cleanupWrapper);
  • app/assets/javascripts/filtered_search/filtered_search_manager.js.es6|24 col 37| document.removeEventListener('page:fetch', this.cleanupWrapper);
  • app/assets/javascripts/logo.js (@brycepj - ✅ )
  • app/assets/javascripts/vue_realtime_listener/index.js.es6|10 col 37| document.removeEventListener('page:fetch', removeAll);
  • app/assets/javascripts/vue_realtime_listener/index.js.es6|16 col 32| document.addEventListener('page:fetch', removeAll);
  • vendor/assets/javascripts/jquery.turbolinks.js (@brycepj - ✅ )

page:before-unload

  • app/assets/javascripts/smart_interval.js.es6|92 col 53| $(document).off('visibilitychange').off('page:before-unload');
  • app/assets/javascripts/smart_interval.js.es6|115 col 28| $(document).on('page:before-unload', () => this.cancel());
  • spec/javascripts/smart_interval_spec.js.es6|167 col 37| $(document).trigger('page:before-unload');

page:change

  • app/assets/javascripts/logo.js (@brycepj - ✅ )
  • app/assets/javascripts/merge_request_widget.js.es6|72 col 31| return $(document).off('page:change.merge_request');
  • app/assets/javascripts/merge_request_widget.js.es6|78 col 23| $(document).on('page:change.merge_request'
  • app/assets/javascripts/sidebar.js.es6|43 col 14| .on('page:change', () => this.renderState())

page:load

  • app/assets/javascripts/render_gfm.js|12 col 25| $(document).on('ready page:load', function() {
  • spec/javascripts/behaviors/autosize_spec.js (@brycepj - ✅ )
  • spec/javascripts/behaviors/requires_input_spec.js (@brycepj - ✅ )
  • spec/javascripts/behaviors/requires_input_spec.js (@brycepj - ✅ )
  • vendor/assets/javascripts/jquery.turbolinks.js (@brycepj - ✅ )

html attributes:

  • app/views/layouts/application.html.haml (@brycepj - ✅ )
  • app/helpers/javascript_helper.rb (@brycepj - ✅ )
  • spec/javascripts/bootstrap_linked_tabs_spec.js.es6 (@brycepj - ✅ )
  • app/views/devise/shared/_omniauth_box.html.haml|9 col 160| = link_to provider_image_tag(provider), omniauth_authorize_path(:user, provider), method: :post, class: (has_icon ? 'oauth-image-link' : 'btn'), "data-no-turbolink" => "true"
  • app/views/import/bitbucket/status.html.haml|85 col 66| = link_to 'import flow', status_import_bitbucket_path, 'data-no-turbolink' => 'true'
  • app/views/profiles/accounts/show.html.haml|85 col 120| = link_to omniauth_authorize_path(:user, provider), method: :post, class: 'provider-btn not-active', "data-no-turbolink" => "true" do
  • app/views/projects/new.html.haml|53 col 158| = link_to status_import_bitbucket_path, class: "btn import_bitbucket #{'how_to_import_link' unless bitbucket_import_configured?}", "data-no-turbolink" => "true" do

Scss:

  • app/assets/stylesheets/framework/progress.scss (@brycepj - ✅ )

What are the relevant issue numbers?

Closes #25624 (closed) #21722 (closed)

EE Compatible Version: 540da9b2

Merge request reports