Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !7504

Allow commit note to be visible if repo is visible

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rémy Coutable requested to merge 23824-activity-page-does-not-show-commits-comments into master Nov 16, 2016
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 4

What does this MR do?

It enforces the :download_code permission in Event#visible_to_user? for commit notes.

I've also added note? && target && in Event#commit_note? and Event#project_snippet_note? for consistency with other similar methods.

Are there points in the code the reviewer needs to double check?

I think it makes sense since commits are visible if the current user has the :download_code ability, so a note of a commit should have the same restrictions.

Closes #23824 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 23824-activity-page-does-not-show-commits-comments