Skip to content
Snippets Groups Projects

`Reset filters` link should only be visible when filters are active

All threads resolved!

What does this MR do?

Adds issuable_filters_present helper method to check for any filters before rendering the reset link.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Reset filters link is always visible.

Screenshots (if relevant)

2016-09-23_15.22.09

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #22457 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Works great! :tada:

    Needs tests though.

  • Reassigned to @lbennett

  • Luke Bennett Added 1 commit:

    Added 1 commit:

    • ee19d8f8 - Added issuable_filters_present to check for active filters before rendering the reset button
  • Luke Bennett Added 662 commits:

    Added 662 commits:

    • ee19d8f8...8a96910c - 661 commits from branch master
    • 3354b5af - Added issuable_filters_present to check for active filters before rendering the reset button
  • Luke Bennett Resolved all discussions

    Resolved all discussions

  • Author Contributor

    Note to miniboss: Don't forget gitlab-org/gitlab-ee!785!

  • Luke Bennett Added 47 commits:

    Added 47 commits:

    • 3354b5af...49d6ca62 - 46 commits from branch master
    • 7cdcf1d8 - Added issuable_filters_present to check for active filters before rendering the reset button
  • Reassigned to @fatihacet

  • Luke Bennett Added 1 commit:

    Added 1 commit:

    • 44361930 - Added issuable_filters_present to check for active filters before rendering the reset button
  • @rspeicher can you review the ruby code here?

  • Reassigned to @rspeicher

  • Robert Speicher Status changed to merged

    Status changed to merged

  • Robert Speicher Mentioned in commit 880530da

    Mentioned in commit 880530da

  • Mentioned in issue #23546 (closed)

  • ~"Pick into Stable" missing!

  • Rémy Coutable Added ~149423 label

    Added ~149423 label

  • Picked into 8-13-stable, will go into 8.13.0-rc4.

    Edited by Rémy Coutable
  • Rémy Coutable Removed ~149423 label

    Removed ~149423 label

  • Actually, I'm waiting for the EE MR to be merged first!

  • Rémy Coutable Added ~149423 label

    Added ~149423 label

  • Picked into 8-13-stable, will go into 8.13.0-rc5.

  • Rémy Coutable Removed ~149423 label

    Removed ~149423 label

  • Robert Speicher Mentioned in commit 0831657e

    Mentioned in commit 0831657e

  • Please register or sign in to reply
    Loading