`Reset filters` link should only be visible when filters are active
Merged
requested to merge 22457-reset-filters-button-should-be-invisible-when-no-filters-are-active into master
All threads resolved!
What does this MR do?
Adds issuable_filters_present
helper method to check for any filters before rendering the reset link.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Reset filters
link is always visible.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #22457 (closed)
Merge request reports
Activity
Added 1 commit:
-
71b2597e - Added
issuable_filters_present
to check for active filters before rendering the reset button
-
71b2597e - Added
Reassigned to @iamphill
Milestone changed to %8.13
- Resolved by Luke Bennett
Reassigned to @lbennett
Added 1 commit:
-
ee19d8f8 - Added
issuable_filters_present
to check for active filters before rendering the reset button
-
ee19d8f8 - Added
Added 662 commits:
-
ee19d8f8...8a96910c - 661 commits from branch
master
-
3354b5af - Added
issuable_filters_present
to check for active filters before rendering the reset button
-
ee19d8f8...8a96910c - 661 commits from branch
Added 47 commits:
-
3354b5af...49d6ca62 - 46 commits from branch
master
-
7cdcf1d8 - Added
issuable_filters_present
to check for active filters before rendering the reset button
-
3354b5af...49d6ca62 - 46 commits from branch
Reassigned to @fatihacet
Added 1 commit:
-
44361930 - Added
issuable_filters_present
to check for active filters before rendering the reset button
-
44361930 - Added
@rspeicher can you review the ruby code here?
Reassigned to @rspeicher
Mentioned in commit 880530da
Mentioned in issue #23546 (closed)
Picked into8-13-stable
, will go into8.13.0-rc4
.Edited by Rémy CoutableMentioned in commit 0831657e
Please register or sign in to reply