Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !5364

Merged
Opened Jul 20, 2016 by Rémy Coutable@rymai🏔Maintainer3 of 3 tasks completed3/3 tasks

Use limit parameter rather than hardcoded value in `ldap:check` rake task

  • Overview 1
  • Commits 2
  • Pipelines 1
  • Changes 2

Originally opened at !4788 (closed) by @rickettm.


What does this MR do?

Fix bug #15344 (closed), so that the limit parameter that is already passed in to the print_users function is actually used, rather than using a hardcoded value.

Are there points in the code the reviewer needs to double check?

No, it is a trivial change.

Why was this MR needed?

This bug causes 100 LDAP users to be displayed even when a different limit is given, which can be annoying.

What are the relevant issue numbers?

Fixes #15344 (closed).

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together
Assignee
Assign to
Reviewer
Request review from
8.10
Milestone
8.10 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab-foss!5364
Source branch: 17862-honour-limit-in-ldap-check

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.