Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !4744

Resolve "Destroying a project causes post_decline_request to be executed"

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Rémy Coutable requested to merge 18755-fix-destroy-project-causes-post_decline_request-to-be-executed into master Jun 17, 2016
  • Overview 14
  • Commits 8
  • Pipelines 0
  • Changes 28

What does this MR do?

Ensure we don't send "access request declined" to access requesters when a project is deleted.

Are there points in the code the reviewer needs to double check?

I've created a service to decouple the notification sending from the AR model.

Why was this MR needed?

Because there was an issue.

What are the relevant issue numbers?

Fixes #18755 (closed), #18750 (closed).

Does this MR meet the acceptance criteria?

  • No CHANGELOG needed.
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 18755-fix-destroy-project-causes-post_decline_request-to-be-executed