Use stub_rails_env for Rails.env stubbing
requested to merge 66966-convert-rails-env-stub-usages-to-use-railshelpers-stub_rails_env-instead into master
What does this MR do?
This MR converts allow(Rails.env)
and expect(Rails.env)
stubs to use RailsHelpers.stub_rails_env
instead.
EE port - https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/16163
Does this MR meet the acceptance criteria?
Conformity
[ ] Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.[ ] Documentation created/updated or follow-up review issue created-
Code review guidelines -
Merge request performance guidelines -
Style guides [ ] Database guides-
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #66966 (closed)
Edited by Rémy Coutable