Skip to content

Use the 'needs' keyword for 'package-and-qa' job

Rémy Coutable requested to merge qa-use-dag-for-package-and-qa-always-job into master

What does this MR do?

Given that:

  1. build-qa-image only takes 5 minutes to finish, e.g. https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/277746904
  2. gitlab:assets:compile pull-cache takes 17 minutes (to be checked) to finish, e.g. https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/277746864
  3. The test stage finishes in 43 minutes on average (the duration of gitlab:assets:compile pull-cache + the duration of review-build-cng since the latter is started once the former finishes)
  4. package-and-qa only needs build-qa-image and gitlab:assets:compile pull-cache to start
  5. package-and-qa can take up to 45 minutes, e.g. https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/277746921
  6. We are saving 43 - 17 = 26 minutes for QA branches pipelines since these branches usually take around 106 to 109 minutes to finish (e.g. https://gitlab.com/gitlab-org/gitlab-ce/pipelines/76302387, https://gitlab.com/gitlab-org/gitlab-ce/pipelines/76302292). This is confirmed by the pipeline for this MR, which finished in 80 minutes "only": https://gitlab.com/gitlab-org/gitlab-ce/pipelines/77749172

I've also moved the package-and-qa-manual and package-and-qa to the qa stage.

TODO:

Example

Before this change, package-and-qa would have started at 10:40 AM UTC (just after review-build-cng finished), but now it started at 10:14 AM UTC, so we saved 26 minutes

Screenshot

QA branch

Screen_Shot_2019-08-22_at_17.19.34

Non-QA branch

Screen_Shot_2019-08-22_at_17.51.20

Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/65609.

Edited by Rémy Coutable

Merge request reports