Skip to content

Replace finished_at with deployed_at for the internal API Deployment entity

Krasimir Angelov requested to merge 56130-deployed_at into master

What does this MR do?

In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31808 we added new attribute finished_at to the internal API Deployement entity to be used instead of created_at. While working on https://gitlab.com/gitlab-org/gitlab-ce/issues/66037 I've noticed that there is a better suited method Deployment#deployed_at that also takes into account the deployment status.

Given FE work has not started and finished_at is not being used this MR replaces finished_at with deployed_at.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #56130 (closed)

Merge request reports