Skip to content

Expose finished_at for the Deployment entity

Krasimir Angelov requested to merge 56130-deployment-date into master

What does this MR do?

We are using last_deployment.deployable.created_at instead of last_deployment.deployable.finished_at in https://gitlab.com/gitlab-org/gitlab-ce/blob/16f3f33e748d61b494f8815501e2a884d114255d/app/assets/javascripts/environments/components/environment_item.vue#L127-137

This MR adds finished_at to DeploymentEntity so that we can show it instead of created_at when listing environments.

https://gitlab.com/gitlab-org/gitlab-ce/issues/56130#note_203602729

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #56130 (closed)

Edited by Grzegorz Bizon

Merge request reports