Skip to content

Moves Protected paths throttling from Omnibus to GitLab Rails

What does this MR do?

Moves protected paths to GitLab-Rails:

  • Adds 4 columns to application_settings
    • 3 to mimic the configuration of existing throttles
    • 1 to store the protected paths on database
  • Set default protected paths (taken from Omnibus)
  • Add new section on admin panel to personalize protected paths configuration
  • This new throttle is active by default.
  • Includes additional protected paths throttles
  • Rack Attack file was renamed to 'rack_attack_gitlab_rails'.rb, otherwise the Omnibus file will overwrite this file.
  • If the settings are enabled, they will take precedence over the Omnibus settings

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64278

Documentation MR - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32773

Screenshots

Protected paths configuration
Screen_Shot_2019-09-10_at_12.52.55_PM

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64278

To do - backend

Edited by Mayra Cabrera

Merge request reports

Loading