Skip to content
Snippets Groups Projects

Moves Protected paths throttling from Omnibus to GitLab Rails

Closed Mayra Cabrera requested to merge mc-moves-protected-path-throttle-to-gitlab-rails into master

What does this MR do?

Moves protected paths to GitLab-Rails:

  • Adds 4 columns to application_settings
    • 3 to mimic the configuration of existing throttles
    • 1 to store the protected paths on database
  • Set default protected paths (taken from Omnibus)
  • Add new section on admin panel to personalize protected paths configuration
  • This new throttle is active by default.
  • Includes additional protected paths throttles
  • Rack Attack file was renamed to 'rack_attack_gitlab_rails'.rb, otherwise the Omnibus file will overwrite this file.
  • If the settings are enabled, they will take precedence over the Omnibus settings

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64278

Documentation MR - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32773

Screenshots

Protected paths configuration
Screen_Shot_2019-09-10_at_12.52.55_PM

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64278

To do - backend

Edited by Mayra Cabrera

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mayra Cabrera added 1 commit

    added 1 commit

    • a731ba66 - Moves protected paths rack attack to gitlab-rails

    Compare with previous version

  • Mayra Cabrera added 84 commits

    added 84 commits

    Compare with previous version

  • Mayra Cabrera resolved all threads

    resolved all threads

  • Mayra Cabrera changed the description

    changed the description

  • Mayra Cabrera added 596 commits

    added 596 commits

    Compare with previous version

  • Mayra Cabrera added 398 commits

    added 398 commits

    Compare with previous version

  • Mayra Cabrera marked the checklist item Handle the throttle on RackAttackGlobal as completed

    marked the checklist item Handle the throttle on RackAttackGlobal as completed

  • Stan Hu mentioned in issue #66471 (moved)

    mentioned in issue #66471 (moved)

  • mentioned in issue #66619 (closed)

  • 🤖 GitLab Bot 🤖 changed milestone to %12.3

    changed milestone to %12.3

  • Mayra Cabrera added 420 commits

    added 420 commits

    Compare with previous version

  • Mayra Cabrera changed the description

    changed the description

  • Mayra Cabrera added 1 commit

    added 1 commit

    • dc7ac58f - [WIP] Moves protected path to gitlab-rails

    Compare with previous version

  • Mayra Cabrera added 666 commits

    added 666 commits

    Compare with previous version

  • Mayra Cabrera changed the description

    changed the description

  • Mayra Cabrera added 1 commit

    added 1 commit

    • eddff87f - [WIP] Moves protected path to gitlab-rails

    Compare with previous version

  • Mayra Cabrera changed the description

    changed the description

  • Mayra Cabrera marked the checklist item Log error on auth.log as completed

    marked the checklist item Log error on auth.log as completed

  • Mayra Cabrera added 72 commits

    added 72 commits

    Compare with previous version

  • Mayra Cabrera marked the checklist item Add new application_settings to UI as completed

    marked the checklist item Add new application_settings to UI as completed

  • Mayra Cabrera changed the description

    changed the description

  • Mayra Cabrera added 112 commits

    added 112 commits

    Compare with previous version

  • Mayra Cabrera added 1 commit

    added 1 commit

    • 87ed144a - [WIP] Moves protected path to gitlab-rails

    Compare with previous version

  • Mayra Cabrera mentioned in merge request !32708 (merged)

    mentioned in merge request !32708 (merged)

  • Mayra Cabrera marked the checklist item Refactor as completed

    marked the checklist item Refactor as completed

  • Mayra Cabrera added 110 commits

    added 110 commits

    Compare with previous version

  • Mayra Cabrera added 1 commit

    added 1 commit

    • eb8f7897 - Moves protected path to gitlab-rails

    Compare with previous version

  • Mayra Cabrera added 1 commit

    added 1 commit

    • 669c00de - Moves protected path to gitlab-rails

    Compare with previous version

  • Mayra Cabrera added 1 commit

    added 1 commit

    • 37b5aa8c - Moves protected path to gitlab-rails

    Compare with previous version

  • Mayra Cabrera marked the checklist item Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. as completed

    marked the checklist item Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. as completed

  • Mayra Cabrera marked the checklist item Code review guidelines as completed

    marked the checklist item Code review guidelines as completed

  • Mayra Cabrera marked the checklist item Merge request performance guidelines as completed

    marked the checklist item Merge request performance guidelines as completed

  • Mayra Cabrera marked the checklist item Style guides as completed

    marked the checklist item Style guides as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading