Skip to content
Snippets Groups Projects

Moves Protected paths throttling from Omnibus to GitLab Rails

Merged Mayra Cabrera requested to merge ee-mc-moves-protected-path-throttle-to-gitlab-rails into master

What does this MR do?

Moves protected paths to GitLab-Rails:

  • Adds 4 columns to application_settings
    • 3 to mimic the configuration of existing throttles
    • 1 to store the protected paths on database
  • Set default protected paths (taken from Omnibus)
  • Add new section on admin panel to personalize protected paths configuration
  • This new throttle is active by default.
  • Includes additional protected paths throttles
  • Rack Attack file was renamed to rack_attack_new.rb, otherwise the Omnibus file will overwrite this file.
  • If the Omnibus settings are present, the application settings are ignored.

Related to #29952 (closed)

Documentation MR - !16540 (merged)

Screenshots

With Omnibus throttle present Without Omnibus throttle
Screen_Shot_2019-09-26_at_11.19.11_AM Screen_Shot_2019-09-19_at_9.40.28_AM

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

To do - backend

  • Move Protected Paths to config/gitlab.yml
  • Handle the throttle on RackAttackGlobal
  • Add specs
  • Log error on auth.log
  • Add new application_settings to UI
  • Refactor
  • Configure protected paths on UI
Edited by Mayra Cabrera

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Stan Hu

      Looks good to me! Perhaps we should build an Omnibus package to ensure that our understanding of how these settings play together is correct?

  • Mayra Cabrera changed the description

    changed the description

  • Mayra Cabrera added 1 commit

    added 1 commit

    • 489e4ff8 - Moves protected path to gitlab-rails

    Compare with previous version

  • Stan Hu added 329 commits

    added 329 commits

    Compare with previous version

  • Stan Hu
  • unassigned @stanhu

  • Mayra Cabrera changed the description

    changed the description

  • Mayra Cabrera added 1 commit

    added 1 commit

    • e497ea1d - Moves protected path to gitlab-rails

    Compare with previous version

  • Mayra Cabrera changed milestone to %12.4

    changed milestone to %12.4

  • Mayra Cabrera added 1 commit

    added 1 commit

    • 49093164 - Moves protected path to gitlab-rails

    Compare with previous version

  • Mayra Cabrera added 625 commits

    added 625 commits

    Compare with previous version

  • Mayra Cabrera changed the description

    changed the description

  • Mayra Cabrera added 1 commit

    added 1 commit

    • bafbb05b - Moves protected path to gitlab-rails

    Compare with previous version

  • Mayra Cabrera
  • thanks for all your help @stanhu :bow:! Could you please take another look?

  • assigned to @stanhu

  • Stan Hu
  • Stan Hu assigned to @mayra-cabrera and unassigned @stanhu

    assigned to @mayra-cabrera and unassigned @stanhu

  • Mayra Cabrera added 567 commits

    added 567 commits

    Compare with previous version

  • Mayra Cabrera changed the description

    changed the description

  • @stanhu could you please take another look? I've responded to your inquiry on !16463 (comment 220195993)

  • assigned to @stanhu

  • Stan Hu approved this merge request

    approved this merge request

  • Stan Hu resolved all threads

    resolved all threads

  • merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading