Skip to content

Improve layout of dropdowns in the metrics dashboard page

What does this MR do?

This MR uses a gl-form-group component layout to wrap the dropdowns in the Prometheus / metrics page in order to improve the user experience on mobile (and desktop).

Before After
image image

Review app: https://gitlab-review-64730-metr-9vgrll.ce.gitlab-review.app/root/autodevops-deploy/environments/1/metrics

Responsiveness

3 Dropdowns Experience:

2019-07-29_17.00.26

Dropdowns and buttons Experience: (Custom dashboard URL and Add metric button in EE):

2019-08-05_15.11.08

  • Add metric button is only available in EE but was mocked during development, its layout was considered.
  • Stopped using some dashboard specific CSS, this CSS was removed.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #64730 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading