Add frozen_string_literal to spec/features

What does this MR do?

Add frozen_string_literal to spec/features

https://gitlab.com/gitlab-org/gitlab-ce/issues/59758

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Performance and testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

changed milestone to %12.2

added [deprecated] Accepting merge requests backend backstage [DEPRECATED] test labels

changed the description

	1 Warning
	This merge request is quite big (more than 1050 lines changed), please consider splitting it into multiple merge requests.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
test for spec/features/*	No reviewer available	No maintainer available

Generated by Danger

added 1 commit

• 1bf84455 - Add frozen_string_literal to spec/features

Compare with previous version

@tigerwnz Can you please review - probably easier to git show locally :)

assigned to @tigerwnz and unassigned @tkuah

@tkuah Sure thing! Looks like there are some legitimate spec failures so I'll assign to you also, but I'll start looking anyway.

assigned to @tkuah

added 1 commit

• 5683bc83 - Frozen string cannot change encoding

Compare with previous version

added 1 commit

• 696ff537 - Frozen string cannot change encoding

Compare with previous version

added 1 commit

• 20aaf2ae - Fix can't modify frozen String errors

Compare with previous version

added 2 commits

• 021f4e55 - Frozen string cannot change encoding
• c1a6f21f - Fix can't modify frozen String errors

Compare with previous version

resolved all threads

added 87 commits

• c1a6f21f...9e91ae15 - 85 commits from branch master
• 73e84885 - Add frozen_string_literal to spec/features
• 8be61f76 - Fix can't modify frozen String errors

Compare with previous version

@tigerwnz WDYT of this MR ? :)

unassigned @tkuah

approved this merge request

unassigned @tigerwnz

@rymai Can you please review this MR ? Thanks

assigned to @rymai

resolved all threads

@tkuah Thank you, looks good to me!

Do you have an EE MR for EE-specific spec files too?

approved this merge request

merged

mentioned in commit aa0d8b4c

Thanks @rymai !

Do you have an EE MR for EE-specific spec files too?

Not yet, that will come soon when I have some downtime :)

removed [deprecated] Accepting merge requests label

added groupconfigure [DEPRECATED] label

changed the description

added groupenvironments label and removed groupconfigure [DEPRECATED] label