Add frozen_string_literal: true to specs

Danger requires frozen_string_literal: true for new .rb files

https://gitlab.com/gitlab-org/gitlab-ce/issues/47424 added the magic comment for all application files. The next major offender is spec files. Since we move spec files often, we should add this magic comment to all existing spec .rb files too.

Use this sed script which could be useful to replace:

gg -L frozen_string_literal <directory> | grep "\.rb$"  | xargs -n1 sed -i "" '1s/^/# frozen_string_literal: true\'$'\n\\'$'\n/'

added backend backstage [DEPRECATED] test labels

mentioned in issue #47424 (closed)

mentioned in merge request !26790 (merged)

mentioned in merge request !26791 (merged)

changed the description

Since we move spec files often, we should look into adding this magic comment to all existing spec .rb files too.

Ah, that makes sense, since Danger would then fire on this "new" file, further bloating the original issue with ALL of those references about frozen string .

changed milestone to %Backlog

added [deprecated] Accepting merge requests label

changed the description

I'm not sure there is a lot of value in adding this to specs, but we can do it for consistency

changed the description

mentioned in merge request !27187 (merged)

mentioned in merge request !27266 (merged)

mentioned in merge request !27267 (merged)

mentioned in merge request !27341 (merged)

mentioned in commit 93a44e13

mentioned in commit 3ca026f9

mentioned in commit 802580d6

mentioned in commit e0f5705a

mentioned in commit af1bf70c

mentioned in commit eff334ec

mentioned in commit 9e9b9799

mentioned in commit 4539acea

mentioned in commit 1035a4d2

mentioned in merge request !31129 (merged)

mentioned in merge request !31130 (merged)

mentioned in merge request !31131 (merged)

mentioned in merge request !31132 (merged)

mentioned in commit 01ab423e

mentioned in commit f0391c25

mentioned in commit 1bf84455

mentioned in commit 42467956

mentioned in commit 7bb15864

mentioned in commit 81818f7d

mentioned in commit 47826fe7

mentioned in commit 94bb6604

mentioned in commit 73e84885

mentioned in commit f540ffce

mentioned in commit 1226616e

mentioned in commit 9d133e6f

mentioned in commit 7165299a

mentioned in commit 3d4f8cc7

mentioned in commit 7e03465f

mentioned in commit 9fc3e1dd

mentioned in commit a2956679

mentioned in merge request !32094 (merged)

mentioned in commit 8c42a0ea

mentioned in commit af417c15

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue

marked this issue as related to gitlab#27703 (closed)