Add frozen_string_literal to spec/lib (part 1)

What does this MR do?

Add frozen_string_literal to half of the offending files in spec/lib (Part 1: 394/798 files)

Will do the other 400 files in another MR

https://gitlab.com/gitlab-org/gitlab-ce/issues/59758

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Performance and testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

changed milestone to %Backlog

added [deprecated] Accepting merge requests backend backstage [DEPRECATED] test labels

changed milestone to %12.2

changed the description

	1 Warning
	This merge request is quite big (more than 826 lines changed), please consider splitting it into multiple merge requests.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Ross Fuhrman (@rossfuhrman)	Stan Hu (@stanhu)

Generated by Danger

added 1 commit

• 01ab423e - Add frozen_string_literal to spec/lib

Compare with previous version

Can you please review @rossfuhrman ? Might be faster to git show locally

assigned to @rossfuhrman and unassigned @tkuah

Looks like there's some failures, will take this back

assigned to @tkuah and unassigned @rossfuhrman

added 1 commit

• 42467956 - Add frozen_string_literal to spec/lib (part 1)

Compare with previous version

changed title from Add frozen_string_literal to spec/lib to Add frozen_string_literal to spec/lib (part 1)

changed the description

added 2 commits

• 87286e3f - Fix cannot modify frozen string
• cbd7db21 - Frozen string cannot change encoding

Compare with previous version

added 3 commits

• 7bb15864 - Add frozen_string_literal to spec/lib (part 1)
• 385f7de2 - Fix cannot modify frozen string
• 5e9cf216 - Frozen string cannot change encoding

Compare with previous version

added 2 commits

• d48e63b0 - Frozen string cannot change encoding
• d9741286 - Fix can't modify frozen String

Compare with previous version

added 3 commits

• 81818f7d - Add frozen_string_literal to spec/lib (part 1)
• fc9fb35d - Fix cannot modify frozen string
• 0cceb109 - Frozen string cannot change encoding

Compare with previous version

added 3 commits

• 47826fe7 - Add frozen_string_literal to spec/lib (part 1)
• 03977308 - Fix cannot modify frozen string
• 917e106d - Frozen string cannot change encoding

Compare with previous version

added 1 commit

• a981d273 - Frozen string cannot change encoding

Compare with previous version

changed the description

added 87 commits

• a981d273...9e91ae15 - 85 commits from branch master
• f540ffce - Add frozen_string_literal to spec/lib (part 1)
• d9db8d85 - Fix cannot modify frozen string

Compare with previous version

@rossfuhrman This is ready for review now finally. Can you please review ? Might be faster to git show locally

assigned to @rossfuhrman and unassigned @tkuah

@tkuah This looks good to me. Thanks for the git show tip!

Can you give this a review @stanhu?

assigned to @stanhu and unassigned @rossfuhrman

approved this merge request

merged

@tkuah Thanks!

mentioned in commit ef3e6785

removed [deprecated] Accepting merge requests label

added groupconfigure [DEPRECATED] label

changed the description

added groupenvironments label and removed groupconfigure [DEPRECATED] label