Changed `author_avatar` to inline-block class
What does this MR do?
Since I encountered the problem of strange distorted avatars in the commitview, I went ahead and checked how this strange behaviour can be eliminated.
author_avatar utilized d-sm-inline as css_class, but with d-sm-inline-block the behaviour is as expected and described in #64746 (closed).
This MR can be seen as proof-of-concept for further discussion. I sure can think of better ways to implement this instead of doing an hardcoded change. But probably the d-sm-inline class is not needed for the avatars anymore.
Screenshots taken from gitlab-development-kit example project
| before | after |
|---|---|
 |
 |
The underlying problem can be encountered for example by blocking acces to gravatar and visiting https://gitlab.com/gitlab-org/gitlab-ce/commit/f3ce7a37a4aa00c0af614757087b6536c9ef701f 
.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #64746 (closed)