Commit authors avatar sretched in commit view if no image is loaded
Summary
If in your network environment a host is blocked by firewall ruleset, for example gravatar, the commit authors avatar is weird stretched. While this issue does not occur in the tree view for example.
Steps to reproduce
- Disable gravatar or server where avatars are stored by firewall or HOST file redirection.
- go to the commit page in a repository from a commiter with gravatar or blocked service and you will see a stretched oval avatar
- go to the tree page of this commit and you will discover there is no problem with the avatar
Example Project
Because this is not project specific behaviour, this would provide no benefit.
What is the current bug behavior?
Wrong or diverse style of the avatar.
What is the expected correct behavior?
It should not have an impact on the avatar if an image resource can be reached or not.
Relevant logs and/or screenshots
commit view | tree view |
---|---|
![]() |
![]() |
Output of checks
This bug happens on GitLab.com, and on Gitlab-development-kit and on GitLab CE 12.0.3.
Possible fixes
Use same div container and styling on both places, _commit_box.html.haml#L13
Edited by Marc Schwede