Skip to content

Fix saving domain without certificate for auto_ssl

Vladimir Shushlin requested to merge fix-only-https-pages-domains into master

What does this MR do?

We added support for Let's Encrypt certificates, but to enable that user currently need to switch off "Force ssl" flag.

This MR just fixes validations.

We already properly handle domains without certificates while updating configuration: https://gitlab.com/gitlab-org/gitlab-ce/blob/12563bb37c3b439f1bf12b2fe66fb2034bfc24a0/app/services/projects/update_pages_configuration_service.rb#L48

https://gitlab.com/gitlab-org/gitlab-ce/issues/64432

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports