Skip to content
Snippets Groups Projects

Vue-i18n: autofix for app/assets/javascripts/performance_bar directory

Merged Ezekiel Kigbo requested to merge vue-i18n-js-performance-bar-directory into master
All threads resolved!

What does this MR doc

Externalizes strings found by "eslint-plugin-vue-i18n"

This MR externalizes strings in files located under app/assets/javascripts/performance_bar which have been detected by eslint-plugin-vue-i18n.

Note: eslint-plugin-vue-i18n is not part of our codebase yet but will eventually be added in a separate MR.

EE Port

EE Port

What are the relevant issue numbers?

#63457 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nathan Friend approved this merge request

    approved this merge request

  • @ekigbo Looks good to me :thumbsup: Just one question about i18n namespacing. I'll go ahead and approve this now, though.

  • Ezekiel Kigbo added 1 commit

    added 1 commit

    • 40ba4a03 - Namespace performance bar translations

    Compare with previous version

  • Ezekiel Kigbo resolved all discussions

    resolved all discussions

  • assigned to @ekigbo

  • Ezekiel Kigbo unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Author Developer

    Hey @kushalpandya Are you able to do a maintainer review on this? Also an EE Port

  • Ezekiel Kigbo assigned to @kushalpandya and unassigned @ekigbo

    assigned to @kushalpandya and unassigned @ekigbo

  • Kushal Pandya approved this merge request

    approved this merge request

  • merged

  • Kushal Pandya mentioned in commit b0845b62

    mentioned in commit b0845b62

  • Setting devopsmanage based on ~"Manage".

  • Setting devopsmanage based on ~"Manage".

  • Please register or sign in to reply
    Loading