Vue-i18n: autofix for app/assets/javascripts/performance_bar directory
What does this MR doc
Externalizes strings found by "eslint-plugin-vue-i18n"
This MR externalizes strings in files located under app/assets/javascripts/performance_bar which have been detected by eslint-plugin-vue-i18n.
Note: eslint-plugin-vue-i18n is not part of our codebase yet but will eventually be added in a separate MR.
EE Port
What are the relevant issue numbers?
Merge request reports
Activity
2 Warnings The title of this merge request is longer than 72 characters and would violate our commit message rules when using the Squash on Merge feature. Please consider adjusting the title, or rebase the commits manually and don’t use Squash on Merge. 19a0f957: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Nathan Friend ( @nfriend
)Kushal Pandya ( @kushalpandya
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖changed milestone to %12.1
added 183 commits
-
601fc9c5...fa54a486 - 182 commits from branch
master
- 19a0f957 - Vue-i18n: app/assets/javascripts/performance_bar/ directory
-
601fc9c5...fa54a486 - 182 commits from branch
- Resolved by Nathan Friend
Hey @nfriend mind reviewing this MR pls?
- Resolved by Ezekiel Kigbo
@ekigbo Looks good to me
Just one question about i18n namespacing. I'll go ahead and approve this now, though.unassigned @nfriend
assigned to @ekigbo
Hey @kushalpandya Are you able to do a maintainer review on this? Also an EE Port
assigned to @kushalpandya and unassigned @ekigbo
mentioned in commit b0845b62
mentioned in issue gitlab-org/release/tasks#840 (closed)
mentioned in issue gitlab-org/release/tasks#841 (closed)
Setting devopsmanage based on ~"Manage".
added devopsfoundations label
Setting devopsmanage based on ~"Manage".