Skip to content

Refactor AfterCommitQueue.inside_transaction?

Andrew Newdigate requested to merge in-transaction into master

What does this MR do?

Moves the AfterCommitQueue.inside_transaction? to GitLab::Database.inside_transaction?

Required by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29774 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29928.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable

Merge request reports