Disallow the review-deploy and review-qa-smoke jobs to fail
What does this MR do?
Based on the latest data gathered on the success rate of the review-deploy
job, I think it's time we disallow this job to fail: https://gitlab.com/gitlab-org/quality/team-tasks/issues/93.
Any repeated failure can be either an actual failure due to the changes made in a MR, or an infrastructure issue, that is most probably transient and that should pass after a few retries/waiting a bit.
What to do if the review jobs keep failing?
- If the
review-deploy
job keep failing (note that we already retry it twice), please ping us in the#quality
channel and/or create a Quality ~bug issue with a link to your merge request. Note that the deployment failure can reveal a actual problem introduced in your merge request (i.e. this isn't necessarily a transient failure)! - If the
review-qa-smoke
job keep failing (note that we already retry it twice), please check the job's logs, you could discover an actual problem introduced in your merge request (you can even download the artifacts to see screenshots of the page at the time the failures occurred). If you don't find the cause of the failure or if it seems unrelated to your change, please ping us in the#quality
channel and/or create a Quality ~bug issue with a link to your merge request.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
-
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable