Skip to content

Disable HTTP for the nginx-ingress Review App service

Rémy Coutable requested to merge disable-http-for-review-apps into master

What does this MR do?

Disable the HTTP port of the nginx-ingress service since we should only use the HTTPS port.

That should help reduce the number of firewall rules used by Review Apps (see https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6642#note_165155067).

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports