Skip to content

Get rid of the user_namespace API helper method

Rémy Coutable requested to merge get-rid-of-user-namespace-method into master

What does this MR do?

This gets rid of the user_namespace API helper which is used only once and doesn't have an explicit behavior (it does a permission check with an early return so it should end with a !; it memoizes its return value in an instance variable which is never explicitely used).

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/20728.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable

Merge request reports