Skip to content

Fix ApplicationSetting development seed

Rémy Coutable requested to merge 60278-fix-development-seed into master

What does this MR do?

It could happen that there's a cached (in Redis) ApplicationSetting record, and calling Gitlab::CurrentSettings.current_application_settings only returns it instead of creating a new DB record, which makes the ApplicationSetting.current_without_cache.update! call fail.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #60278 (closed)

Merge request reports